-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename idobo to idobao/id75, move to vendor folder #15661
Conversation
@vinorodrigues let's continue the discussion in #14468 here Previously: #14468 (comment) |
The question here is weather Are the same thing. On the idobao site, we have this: In the first drop link, we have this: And the buying link in the readme.md says https://drop.com/buy/id75-hot-swappable-ortholinear-keyboard-kit Thus I have concluded that these 3 links are the same board, and are made by IDOBAO by merit of the first link |
Have a look at the 3 kb's you provided links to above. Specifically the side profile. The 2x DROP's are flat ... i.e. top of case and bottom of case are equal in height, where as the Idobao is angled ... i.e. bottom is lower than top. These boards are not the same. They may well share the same PCB, but the code on QMK is specifically for the DROP variant (your first link). Moving this to the Idabao folder will cause confusion with the 330 users out there that will look for it in its original location, or at the very least a Drop vendor folder. |
IDOBAO sells the flat variant too, although apparently only on AliExpress: |
from the idobao server We have aliases for keyboard compilation, we can just alias idobo to idobao/id75 |
good to go then :) |
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist