Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename idobo to idobao/id75, move to vendor folder #15661

Merged
merged 3 commits into from
Jan 16, 2022
Merged

Conversation

peepeetee
Copy link
Contributor

@peepeetee peepeetee commented Dec 30, 2021

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 30, 2021
@peepeetee
Copy link
Contributor Author

@vinorodrigues let's continue the discussion in #14468 here

Previously: #14468 (comment)

@peepeetee
Copy link
Contributor Author

The question here is weather
https://drop.com/buy/id75-hot-swappable-ortholinear-keyboard-kit
https://drop.com/buy/xd75-aluminum-mechanical-keyboard
https://idobao.net/collections/60-layout/products/idobao-id75v1-hot-swappable-mechanical-keyboard-kit

Are the same thing.

On the idobao site, we have this:
image
Which points, well, here.

In the first drop link, we have this:
https://drop.com/buy/xd75-aluminum-mechanical-keyboard/reviews/2493503?utm_source=linkshare&referer=F9X53K

And the buying link in the readme.md says https://drop.com/buy/id75-hot-swappable-ortholinear-keyboard-kit

Thus I have concluded that these 3 links are the same board, and are made by IDOBAO by merit of the first link

@vinorodrigues
Copy link
Contributor

Have a look at the 3 kb's you provided links to above. Specifically the side profile. The 2x DROP's are flat ... i.e. top of case and bottom of case are equal in height, where as the Idobao is angled ... i.e. bottom is lower than top. These boards are not the same. They may well share the same PCB, but the code on QMK is specifically for the DROP variant (your first link).

Moving this to the Idabao folder will cause confusion with the 330 users out there that will look for it in its original location, or at the very least a Drop vendor folder.

@sigprof
Copy link
Contributor

sigprof commented Dec 30, 2021

IDOBAO sells the flat variant too, although apparently only on AliExpress:
https://www.aliexpress.com/item/4000378394653.html
I don't really understand what is happening here.

@peepeetee
Copy link
Contributor Author

peepeetee commented Dec 31, 2021

Have a look at the 3 kb's you provided links to above. Specifically the side profile. The 2x DROP's are flat ... i.e. top of case and bottom of case are equal in height, where as the Idobao is angled ... i.e. bottom is lower than top. These boards are not the same. They may well share the same PCB, but the code on QMK is specifically for the DROP variant (your first link).

Moving this to the Idabao folder will cause confusion with the 330 users out there that will look for it in its original location, or at the very least a Drop vendor folder.

image

from the idobao server

We have aliases for keyboard compilation, we can just alias idobo to idobao/id75

@vinorodrigues
Copy link
Contributor

from the idobao server

good to go then :)

@drashna drashna requested a review from a team January 6, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants